Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Add information about writing bats unit tests #55

Merged
merged 3 commits into from
Nov 7, 2018
Merged

Conversation

adilyse
Copy link
Contributor

@adilyse adilyse commented Nov 6, 2018

This documentation gives a description of how the bats tests are
structured, as well as giving several examples of common test patterns.

This documentation gives a description of how the bats tests are
structured, as well as giving several examples of common test patterns.
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a couple suggestions inline but all optional and you have more context than me if they are good ones!

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Clarified the test naming by including the full first line pattern
that includes the name.
For testing two conditions in the same test, it is reasonable to
follow the existing test patterns and run `helm template` each time.
When testing more conditions, it starts to make sense to separate
the rendering of the yaml from the condition finding and testing.
This commit adds a note to that effect.
@adilyse adilyse merged commit 6f0e412 into master Nov 7, 2018
@adilyse adilyse deleted the docs/bats-testing branch November 7, 2018 20:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants